WebSVN – spk – Diff – /libspk/src/File.cpp

 	if ( !this->CompressData(compressionType, progress) )
 		return false;
 	return true;
+}
-unsigned char *C_File::CompressToData(int compressionType, unsigned long *outSize, CProgressInfo *progress, int level)
+unsigned char* C_File::CompressToData(int compressionType, size_t* outSize, CProgressInfo* progress, int level)
+{
+	if (outSize) *outSize = 0;
-	unsigned long comprLen = m_lDataSize;
+	size_t initialLen = m_lDataSize;
-	if ( comprLen < 100 )		comprLen = 200;
+	if (initialLen < 100) initialLen = 200;
-	else if ( comprLen < 1000 )	comprLen *= 2;
+	else if (initialLen < 1000) initialLen *= 2;
-	comprLen += 1000;
+	initialLen += 1000;
-	switch(compressionType)
-	{
-		case SPKCOMPRESS_ZLIB:
-			{
-				unsigned char *compr = (unsigned char *)calloc(comprLen, 1);
-				int err = Z_NOTENOUGH_BUF;
-				while ( err == Z_NOTENOUGH_BUF )
-				{
-					err = compress2 ( compr, &comprLen, (const unsigned char *)m_sData, m_lDataSize, (progress) ? progress->GetDonePointer() : 0, level );
-					if ( err == Z_NOTENOUGH_BUF )
-					{
-						comprLen += (CHUNK * 2);
-						compr = (unsigned char *)realloc(compr, comprLen);
-					}
-					else
-						break;
-				}
-				// if its compressed ok, remove old data and use new one
+	switch (compressionType)
+	{
-				if ( err == Z_OK )
+	case SPKCOMPRESS_ZLIB:
-				{
+	{
-					unsigned char *retData = new unsigned char[comprLen];
+		unsigned long comprLen = static_cast<unsigned long>(initialLen);
-					(*outSize) = comprLen;
+		unsigned char* compr = (unsigned char*)calloc(comprLen, 1);
-					memcpy(retData, compr, comprLen);
+		if (!compr) return NULL;
-					free(compr);
+		int err = Z_NOTENOUGH_BUF;
-					return retData;
+		while (err == Z_NOTENOUGH_BUF)
-				}
+		{
+			err = compress2(compr, &comprLen, (const unsigned char*)m_sData, m_lDataSize,
+				(progress) ? progress->GetDonePointer() : 0, level);
+			if (err == Z_NOTENOUGH_BUF)
+			{
+				unsigned long newLen = comprLen + (CHUNK * 2);
+				unsigned char* newCompr = (unsigned char*)realloc(compr, newLen);
+				if (!newCompr) { free(compr); return NULL; }
-				free(compr);
+				compr = newCompr;
-				return NULL;
+				comprLen = newLen;
+			}
-			break;
+		}
-		case SPKCOMPRESS_LZMA:
+		if (err == Z_OK && comprLen > 0)
-			{
+		{
-				unsigned char *compr = (unsigned char *)malloc(comprLen);
+			unsigned char* retData = new (std::nothrow) unsigned char[comprLen];
+			if (!retData) { free(compr); return NULL; }
+			memcpy(retData, compr, comprLen);
-				if (!compr) {
+			free(compr);
+			if (outSize) *outSize = static_cast<size_t>(comprLen);
+			return retData;
+		}
+		free(compr);
-					return NULL;
+		return NULL;
-				}
+	}
+	break;
+	case SPKCOMPRESS_LZMA:
+	{
+		size_t comprLen = initialLen;
+		unsigned char* compr = new (std::nothrow) unsigned char[comprLen];
+		if (!compr) return NULL;
-				SRes res = Lzma86_Encode((Byte *)compr, (size_t *)&comprLen, (const Byte *)m_sData, (size_t)m_lDataSize, level, LZMA_DICT, SZ_FILTER_NO, (progress) ? progress->GetDonePointer() : NULL);
+		SRes res = Lzma86_Encode((Byte*)compr, (size_t*)&comprLen, (const Byte*)m_sData, (size_t)m_lDataSize,
+			level, LZMA_DICT, SZ_FILTER_NO, (progress) ? progress->GetDonePointer() : NULL);
-				if ( res == SZ_OK )
+		if (res == SZ_OK && comprLen > 0)
-				{
+		{
-					unsigned char *retData = new unsigned char[comprLen];
+			unsigned char* retData = new (std::nothrow) unsigned char[comprLen];
-					(*outSize) = comprLen;
+			if (!retData) { delete[] compr; return NULL; }
-					memcpy(retData, compr, comprLen);
+			memcpy(retData, compr, comprLen);
-					free(compr);
+			delete[] compr;
+			if (outSize) *outSize = comprLen;
-					return retData;
+			return retData;
-				}
+		}
-				free(compr);
+		delete[] compr;
-				return NULL;
+		return NULL;
-			}
+	}
-			break;
+	break;
+	}
 	return NULL;
+}
 	if ( m_iDataCompression != SPKCOMPRESS_NONE )
 		return true;
 	m_lUncomprDataSize = m_lDataSize;
-	unsigned long comprLen = m_lDataSize;
+	size_t comprLen = static_cast<size_t>(m_lDataSize);
 	if ( comprLen < 100 )
 		comprLen = 200;
 	else if ( comprLen < 1000 )
 		comprLen *= 2;
 	comprLen += 1000;
 	// best compression, attempt to compress the file multiple times until we get the best one
 	if ( compressionType == SPKCOMPRESS_BEST )
+	{
 		int compress[] = { SPKCOMPRESS_ZLIB, SPKCOMPRESS_LZMA };
 		int bestCompress = -1;
-		unsigned int bestSize = 0;
+		size_t bestSize = 0;
 		unsigned char *bestCompr = NULL;
 		for ( int i = 0; i < 2; i++ )
+		{
-			unsigned long checkSize = 0;
+			size_t checkSize = 0;
 			unsigned char *compr = this->CompressToData(compress[i], &checkSize, progress, level);
 			if ( compr )
+			{
 				if ( checkSize < bestSize || bestCompress == -1 )
+				{
+		{
 			DeleteData ();
 			m_sData = compr;
 			m_lDataSize = len;
 			m_iDataCompression = SPKCOMPRESS_NONE;
 			return true;
 		}
+	}
 	return false;
+}
 	char    dateString[100];
 	time_t n = m_tTime;
 	currDate = localtime(&n);
 	strftime(dateString, sizeof dateString, "(%d/%m/%Y) %H:%M", currDate);
 	return Utils::WString(dateString);
+}
 		case SPKINSTALL_ORIGINAL_BACKUP_FAIL:
 			errorStr = L"Unable to back up original file: %1";
 			break;
 		case SPKINSTALL_ORIGINAL_RESTORE:
 			errorStr = L"Restoring original file: %1";
 			break;
 		case SPKINSTALL_ORIGINAL_RESTORE_FAIL:
 			errorStr = L"Unable to restore original file: %1";
 			break;
 		case SPKINSTALL_FAKEPATCH:
 			errorStr = L"Shifted fake patch: %1 to %2";
 		CFileIO File(filePointer());
 		if ( File.startRead() ) data = File.readAll(&datasize);
+	}
 	if ( !data )
 	{
 		if ( !m_lDataSize )
+		{
 			if ( !this->ReadFromFile() )
 				return NULL;
+		}
 		data = new unsigned char[datasize];
 		memcpy ( data, m_sData, datasize );
+	}
 	if ( data )
 	{
 		unsigned char *newdata = UnPCKData ( data, datasize, len, CheckPCK() );
-		delete data;
+		delete[] data;
 		return newdata;
+	}
 	return NULL;
+}
 	return NULL;
+}
 unsigned char *UnPCKData ( unsigned char *data, size_t datasize, size_t *len ) { return UnPCKData(data, datasize, len, IsDataPCK(data, datasize)); }
-unsigned char *UnPCKData ( unsigned char *data, size_t datasize, size_t *len, bool nocrypt )
+unsigned char* UnPCKData(unsigned char* data, size_t datasize, size_t* len, bool nocrypt)
+{
-	bool isPCK = IsDataPCK(data, datasize);
+	if (!data || datasize <; 8) { // Minimum size for header + length
+		if (len) *len = 0;
+		return nullptr;
+	}
+	bool isPCK = IsDataPCK(data, datasize);
-	unsigned char *newData = data;
+	unsigned char* newData = data;
-	unsigned char *tempData = NULL;
+	unsigned char* tempData = nullptr;
-	if ( nocrypt )
+	if (nocrypt) {
-	{
-		tempData = new unsigned char[datasize];
+		tempData = new (std::nothrow) unsigned char[datasize];
-		newData = tempData;
+		if (!tempData) { if (len) *len = 0; return nullptr; }
-		memcpy(newData, data, datasize);
+		memcpy(tempData, data, datasize);
-		unsigned char magic = newData[0] ^ 0xC8;
+		unsigned char magic = tempData[0] ^ 0xC8;
-		for ( size_t i = 1; i <; datasize; i++ )
+		for (size_t i = 1; i <; datasize; i++)
-			newData[i] ^= magic;
+			tempData[i] ^= magic;
-		++newData;
+		newData = tempData + 1;
-		--datasize;
+		datasize -= 1;
+	}
+	if (datasize < 4) { // Not enough data for length
+		if (tempData) delete[] tempData;
+		if (len) *len = 0;
+		return nullptr;
 	}
-	// create data buffer
+	// Read uncompressed length safely
-	size_t *uncomprLenSize = (size_t*)(newData + (datasize - 4));
+	size_t lenPos = datasize - 4;
-	unsigned long uncomprLen = (unsigned long)*uncomprLenSize;
+	unsigned long uncomprLen = 0;
+	memcpy(&uncomprLen, newData + lenPos, 4);
-	if ( uncomprLen > (datasize * 100) )
+	if (uncomprLen > datasize * 100 || uncomprLen == 0) {
+		if (tempData) delete[] tempData;
+		if (len) *len = 0;
+		return nullptr;
-	{
+	}
+	unsigned char* uncompr = new (std::nothrow) unsigned char[uncomprLen + 1];
+	if (!uncompr) {
-		if ( tempData ) delete []tempData;
+		if (tempData) delete[] tempData;
-		*len = 0;
+		if (len) *len = 0;
-		return NULL;
+		return nullptr;
 	}
-	unsigned char *uncompr = new unsigned char[uncomprLen + 1];
+	memset(uncompr, 0, uncomprLen + 1);
-	if ( !uncompr ) {
+	// Parse header
+	size_t bufOffset = PCKHEADERSIZE;
+	if (datasize < bufOffset + 8) { // Not enough data for header and footer
-		if ( tempData ) delete []tempData;
+		if (tempData) delete[] tempData;
+		delete[] uncompr;
+		if (len) *len = 0;
-		return NULL;
+		return nullptr;
+	}
+	unsigned char flag = newData[3];
-	memset ( uncompr, 0, sizeof(uncompr) );
+	unsigned char* buf = newData + bufOffset;
-	// find header size
-	unsigned char *buf = newData + PCKHEADERSIZE;
-//	buf = data + (6 + sizeof(time_t));
-	char flag = newData[3];
-	if ( flag & GZ_FLAG_EXTRA )
+	if (flag & GZ_FLAG_EXTRA) {
-	{
+		if (datasize < bufOffset + 2) { if (tempData) delete[] tempData; delete[] uncompr; if (len) *len = 0; return nullptr; }
 		size_t xlen = *((short int*)(buf));
+		buf += 2;
 		buf += xlen;
+	}
-	if ( flag & GZ_FLAG_FILENAME )
+	if (flag & GZ_FLAG_FILENAME) {
-	{
-		char *origname = (char*)(buf);
+		char* origname = (char*)(buf);
-		buf += strlen (origname) + 1;
+		buf += strlen(origname) + 1;
 	}
-	if ( flag & GZ_FLAG_COMMENT )
+	if (flag & GZ_FLAG_COMMENT) {
-	{
-		char *comment = (char*)(buf);
+		char* comment = (char*)(buf);
 		buf += strlen(comment) + 1;
+	}
-	if ( flag & GZ_FLAG_HCRC )
+	if (flag & GZ_FLAG_HCRC) {
 		buf += 2;
-	long bufSize = (long)(datasize - (buf-newData) - 8);
+	}
-	int err = uncompress2 ( uncompr, &uncomprLen, buf, bufSize );
+	long bufSize = (long)(datasize - (buf - newData) - 8);
-	if ( err != Z_OK )
+	if (bufSize <= 0) {
+		if (tempData) delete[] tempData;
+		delete[] uncompr;
+		if (len) *len = 0;
+		return nullptr;
-	{
+	}
+	int err = uncompress2(uncompr, &uncomprLen, buf, bufSize);
+	if (err != Z_OK) {
-		if ( tempData ) delete []tempData;
+		if (tempData) delete[] tempData;
-		delete uncompr;
+		delete[] uncompr;
-		*len = 0;
+		if (len) *len = 0;
-		return NULL;
+		return nullptr;
+	}
-	*len = uncomprLen;
+	if (len) *len = uncomprLen;
 	uncompr[uncomprLen] = '\0';
-	if ( tempData ) delete []tempData;
+	if (tempData) delete[](tempData - 1); // tempData was offset by +1
 	return uncompr;
+}
 bool IsDataPCK ( const unsigned char *data, size_t size )
+{

Subversion Repositories spk

(root)/libspk/src/File.cpp – Rev 285 → 308